Add files via upload#6
Open
Ar444ri wants to merge 1 commit into
Open
Conversation
hBuzzy
reviewed
Dec 11, 2023
| private: | ||
| QList<SceneItem *> walls_; | ||
| QList<SceneItem *> coins_; | ||
| SceneItem *player_; |
Owner
There was a problem hiding this comment.
Раз дальше будет сравнения с nullptr, то стоит тут и присвоить nullptr
Comment on lines
+12
to
+15
| } else { | ||
| return new SceneItem((QRectF(0, 0, 60, 60)), QPen(), | ||
| QBrush(Qt::yellow, Qt::SolidPattern), type); | ||
| } |
Owner
There was a problem hiding this comment.
У вас 3 сущности, поэтому лучше иметь 3 конструкции if / else if + 1 else (для случая, когда первые 3 не прошли).
Comment on lines
+56
to
+63
| if (type_ == "Монетка") { | ||
| painter->drawEllipse(geometry_); | ||
|
|
||
| } else if (type_ == "Игрок") { | ||
| painter->drawPolygon(DrawPacmanShape()); | ||
| } else { | ||
| painter->drawRect(geometry_); | ||
| } |
Owner
There was a problem hiding this comment.
Аналогично, лучше выделить 3 сущности + else для исключения.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.